-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disk full on downloads server #3125
Comments
|
|
@nodejs/build-infra What should we do? Has this already happened before? |
Yes, for example: |
I think what @targos suggested in #2162 (comment) is reasonable and I've got some scripts that I use elsewhere which can likely enforce that if we're happy with not retaining all 2Tb of nightlies that we're storing at present. As a "quick fix" I've moved some the v9 nightlies to The obvious concern would be that we might want to do it separately for each version since there were overlapping major versions in the nightlies. Do we want to run the deletion of old stuff past the TSC for approval before implementing anything here? |
@rvagg Do you know the history of the |
I agree as well that what @targos suggested in #2162 (comment) makes sense. I think if we reach consensus an FYI to the TSC in advance of implementing would make sense in case there are any concerns. |
I've got a prototype script that I've tested which will:
The above will delete 2708 of the 2913 Node.js nightlies given the status at the time of posting. |
if something is still mounted with "old" in its name it can probably be deleted - that smells like me doing a disk resize upgrade and leaving the old one around for "some period of time" to be sure that the sync properly happened; it obviously did because I don't remember when I last did this +1 to pruning nightlies, I think the only reason we've baulked on scripting it is that people do rely on them for benchmarking and other hackery -- "here's my cool thing but you need to be running Node.js nightly .... which you can download from here". Question for the TSC with input from other folks that might be prone to do this kind of thing. |
or .. we could just up the disk yet again .. or even better, move to an object store model like we've been talking about since almost the beginning of this current layout. |
The disk is full again. |
From chat in slack for record: Michael Dawson (New) Michael Dawson (New) Michael Dawson (New) |
I also wonder about the canaries? Do we need to keep those beyond something like 1 month? |
On the chakracore side the last one in nightlies was back in 2019. |
I just deleted the contents of |
FWIW, all of our releases/nightlies are backed up on the |
Good shout on the chakracore nightlies given that we do still have the releases if people want to play with that version. However I've reinstated the 'last' one for a few of the versions back across in case anyone wants them since it includes a Node v11 and a v12 which isn't in the chakracore-release directory |
I'm not too familiar with the canaries - how are they identified and what would the requirements be for those? I was planning to implement the above later today but I can hold off if you think there's a concern here. |
I think we can treat canaries the same as nightlies. |
Pruning now ... This is the script I'm using for it if anyone wishes to enhance it (Stored in
|
I'll leave this for any further comments before proceeding. I have NOT updated the index.tab/index.json in those directories (this hasn't been done fo the chakracore-nightlies either) but I goess we should clean them up too with the deletions so I believe the remaining actions are:
|
For reference, this is the current size of the different nodejs artifact directories - there are 1385 v8-canary builds in here totalling 829Gb
|
@sxa I assume that for the v8-canary that is before you have pruned them similarly to what you did for nightlies? |
Correct |
@sxa then I figure we should just prune the canaries in the same was as for nightlies and see if there is an issue |
@targos any concerns if we apply the same scripts that we used/are planning to run regularly on the nightlies to prune older builds. |
ping @targos - if no objections in the next day or so I'll plan to implement this automation on canaries and nightlies at the start of next week. |
I have no objections, but note that while I maintain canary builds, I personally almost never use them. |
crontab enabled for both nightlies and v8 canaries, so closing this. Scheduled once a month and the logs are written to |
Found out because release builds fail to push the binaries:
The text was updated successfully, but these errors were encountered: