Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Job for testing NPM #317

Closed
MylesBorins opened this issue Jan 29, 2016 · 10 comments
Closed

CI Job for testing NPM #317

MylesBorins opened this issue Jan 29, 2016 · 10 comments

Comments

@MylesBorins
Copy link
Contributor

There is not current a CI job for testing NPM afaik.

Should we roll one up, it should be fairly simple to do, in fact we should likely be able to do a small modification to the citgm CI job to do this.

@Fishrock123
Copy link
Contributor

@thealphanerd what's the benefit to using citgm for thus over make test-npm?

@zkat
Copy link

zkat commented Jan 29, 2016

As of nodejs/node#4960 and nodejs/node#4958, make test-npm should pass on non-windows platforms without any modifications. Note that there's some discussion in #4958 about false negatives due to progress bar config, so track that.

@MylesBorins
Copy link
Contributor Author

@Fishrock123 I more meant that the way citgm is setup we could modify the job to call make test-npm instead of citgm and we'd have a CI job ready to run. Just the way it is designed is easy to modify

edit: The idea being cloning the ci job into a new job specifically for testing npm

@MylesBorins
Copy link
Contributor Author

I just went ahead and made it...

https://ci.nodejs.org/job/thealphanerd-npm/

@MylesBorins
Copy link
Contributor Author

MylesBorins commented May 5, 2016

I'm going to re-examine this as a possibility next week... /cc @nodejs/npm

edit: likely only using osx + windows as a target for now

@gibfahn
Copy link
Member

gibfahn commented Jul 25, 2016

@thealphanerd nodejs/node#7867 should mean that make test-npm and vcbuild.bat nosign test-npm generate TAP files (called test-npm.tap) in the node directory.

@MylesBorins
Copy link
Contributor Author

@gibfahn the problems we were having in CI were unrelated to the output. Simply getting the suite to pass was not happening. that being said, tap output is a great start

@maclover7
Copy link
Contributor

Very similar to #234 -- should they be combined or closed?

@gibfahn
Copy link
Member

gibfahn commented Oct 16, 2017

We have gibfahn-test-npm and gibfahn-test-npm-win, which pass on my PR branch (nodejs/node#11540). Once that lands I'll take my name off the jobs and give collaborators access.

Unfortunately I've never seen a green CI run on Linux (macOS is pretty good).

@gibfahn
Copy link
Member

gibfahn commented Mar 12, 2018

@gibfahn gibfahn closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants