-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Job for testing NPM #317
Comments
@thealphanerd what's the benefit to using citgm for thus over |
As of nodejs/node#4960 and nodejs/node#4958, |
@Fishrock123 I more meant that the way citgm is setup we could modify the job to call edit: The idea being cloning the ci job into a new job specifically for testing npm |
I just went ahead and made it... |
I'm going to re-examine this as a possibility next week... /cc @nodejs/npm edit: likely only using osx + windows as a target for now |
@thealphanerd nodejs/node#7867 should mean that |
@gibfahn the problems we were having in CI were unrelated to the output. Simply getting the suite to pass was not happening. that being said, tap output is a great start |
Very similar to #234 -- should they be combined or closed? |
We have gibfahn-test-npm and gibfahn-test-npm-win, which pass on my PR branch (nodejs/node#11540). Once that lands I'll take my name off the jobs and give collaborators access. Unfortunately I've never seen a green CI run on Linux (macOS is pretty good). |
There is not current a CI job for testing NPM afaik.
Should we roll one up, it should be fairly simple to do, in fact we should likely be able to do a small modification to the citgm CI job to do this.
The text was updated successfully, but these errors were encountered: