Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test-npm to use test-npm-package.js #11540

Merged
merged 1 commit into from
Oct 19, 2017
Merged

test: update test-npm to use test-npm-package.js #11540

merged 1 commit into from
Oct 19, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Feb 24, 2017 •
edited
Loading

Also deletes the old test-npm.sh script.

NOTE: Changes to deps/npm are for testing purposes only and won't be landed in the final PR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

This replaces #7867

The tests can be run manually with:

make test-npm

or

vcbuild.bat test-npm

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Feb 24, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Feb 24, 2017

cc/ @nodejs/npm @bnoordhuis @Fishrock123 @mscdex @jkrems (from the previous PR)

@gibfahn gibfahn mentioned this pull request Feb 24, 2017
Closed
4 tasks
@gibfahn
Copy link
Member Author

gibfahn commented Feb 24, 2017 •
edited
Loading

CI: https://ci.nodejs.org/view/MyJobs/job/gibfahn-test-npm/22/ and https://ci.nodejs.org/job/gibfahn-test-npm-win/node=win-vs2015/5/console

@jkrems
Copy link
Contributor

jkrems commented Feb 24, 2017

👍

Fishrock123
Fishrock123 previously requested changes Feb 24, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow, as the person who pretty much always does the npm reviews. Why are we changing this?

@gibfahn
Copy link
Member Author

gibfahn commented Feb 24, 2017 •
edited
Loading

@Fishrock123 do you remember #7867 ? The end result of that PR was that a js script was better than a bash script + a Powershell script (which is what's in #7867). I've got CI jobs set up to run Windows + Unix, and the plan is to be able to do full CI runs on all our platforms.

Note that the script was written by @jkrems for node-inspect, so this just allows us to reuse that script.

EDIT: Note that CI isn't properly passing yet, it'll need to be passing (or only have known npm failures) before this can be merged.

@gibfahn gibfahn self-assigned this Feb 24, 2017
@jasnell
Copy link
Member

jasnell commented Mar 17, 2017

ping @gibfahn :-)

@gibfahn gibfahn force-pushed the test-npm-js branch 3 times, most recently from 84f81c2 to ebf2e50 Compare March 18, 2017 11:34
watilde
watilde reviewed Mar 18, 2017
View reviewed changes
deps/npm/package.json Outdated
@@ -204,7 +204,7 @@
"sprintf-js": "~1.0.3",
"standard": "~6.0.8",
"tacks": "~1.2.2",
"tap": "~9.0.3"
"tap": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will be overwritten when we update npm. I think it's better to not edit the files under the dep directory for a specific reason except deps-update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm just doing this so I can run the tests with the -J option, which is only available in the latest version of tap (that way the tests run 4x faster). This won't land with any changes to deps/npm.

@watilde watilde added the npm Issues and PRs related to the npm client dependency or the npm registry. label Mar 18, 2017
@jasnell jasnell added the wip Issues and PRs that are still a work in progress. label Mar 22, 2017
@refack refack mentioned this pull request May 26, 2017
Closed
2 tasks
@BridgeAR
Copy link
Member

Ping @gibfahn are you still working on this?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Aug 29, 2017
@BridgeAR BridgeAR removed wip Issues and PRs that are still a work in progress. stalled Issues and PRs that are stalled. labels Sep 12, 2017
@BridgeAR
Copy link
Member

Looks like this got rebased and the comments addressed. PTAL @jasnell @nodejs/collaborators

@jasnell
Copy link
Member

jasnell commented Sep 13, 2017

The change still LGTM

@gibfahn
Copy link
Member Author

gibfahn commented Sep 13, 2017

Thanks for fixing up the windows tests @refack .

@nodejs/npm does this LGTY? Once this lands I'll fix up the jobs so we have a node-test-commit-npm job collaborators can run.

@BridgeAR
Copy link
Member

Ping @nodejs/npm @zkat

@gibfahn gibfahn mentioned this pull request Sep 25, 2017
Closed
2 tasks
@iarna iarna self-requested a review September 26, 2017 22:27
@iarna
Copy link
Member

iarna commented Sep 26, 2017

I'll dig through this, this week.

@gibfahn gibfahn force-pushed the test-npm-js branch 4 times, most recently from 6d7f8e4 to 0b24fca Compare October 13, 2017 22:59
@gibfahn gibfahn mentioned this pull request Oct 16, 2017
Closed
@gibfahn
Copy link
Member Author

gibfahn commented Oct 16, 2017

CI: https://ci.nodejs.org/job/node-test-commit/13179/
CI (npm): https://ci.nodejs.org/view/All/job/gibfahn-test-npm/31/ and https://ci.nodejs.org/job/gibfahn-test-npm-win/node=win-vs2015/9/

@gibfahn gibfahn mentioned this pull request Oct 16, 2017
Merged
4 tasks
@BridgeAR
Copy link
Member

I think we can just go ahead and land hits @gibfahn ?

@gibfahn
test: update test-npm to use test-npm-package.js
532d8b2 
Deletes the old test-npm.sh script.

PR-URL: nodejs#11540
Refs: nodejs#7867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@gibfahn gibfahn force-pushed the test-npm-js branch 2 times, most recently from ba5a44b to 532d8b2 Compare October 19, 2017 11:10
@gibfahn gibfahn merged commit 532d8b2 into nodejs:master Oct 19, 2017
@gibfahn gibfahn deleted the test-npm-js branch October 19, 2017 11:16
@gibfahn
Copy link
Member Author

gibfahn commented Oct 19, 2017

Agreed @BridgeAR , it's not perfect, but at least we have the ability to run CI on npm now.

@nodejs/collaborators , you should now have access to:

These run make test-npm and vcbuild.bat test-npm.

MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@gibfahn @MylesBorins
test: update test-npm to use test-npm-package.js
6b1f75d 
Deletes the old test-npm.sh script.

PR-URL: #11540
Refs: #7867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@gibfahn @addaleax
test: update test-npm to use test-npm-package.js
f5e8c46 
Deletes the old test-npm.sh script.

PR-URL: nodejs/node#11540
Refs: nodejs/node#7867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@gibfahn @addaleax
test: update test-npm to use test-npm-package.js
0f05f4c 
Deletes the old test-npm.sh script.

PR-URL: nodejs/node#11540
Refs: nodejs/node#7867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde left review comments

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

@Fishrock123 Fishrock123 Fishrock123 left review comments

@iarna iarna Awaiting requested review from iarna

Assignees

@gibfahn gibfahn

Labels
build Issues and PRs related to build files or the CI. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gibfahn @jkrems @jasnell @BridgeAR @iarna @MylesBorins @refack @Fishrock123 @watilde @nodejs-github-bot