Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Wildcard problem? #3404

Closed
bl-ue opened this issue Jun 15, 2021 · 17 comments
Closed

DNS Wildcard problem? #3404

bl-ue opened this issue Jun 15, 2021 · 17 comments

Comments

@bl-ue
Copy link

bl-ue commented Jun 15, 2021

Problem:
https://asdfiasdfuaspdajlrg.nodejs.org/ is a valid URL. You can put anything in place of asdfiasdfuaspdajlrg.

@nschonni
Copy link
Member

@nodejs/build I'm not sure if this is something on your side

@bnb
Copy link

bnb commented Jun 15, 2021

we should do something about this. +1 to fixing.

@jbergstroem
Copy link
Member

The tricky part is finding the legacy reason for why adding a wildcard in the first place. I can look around a bit.

@ovflowd
Copy link
Member

ovflowd commented Mar 21, 2023

@nodejs/build we talked about this last week, right?

@SEWeiTung

This comment was marked as outdated.

@ovflowd

This comment was marked as outdated.

@ovflowd ovflowd transferred this issue from nodejs/nodejs.org Jul 3, 2023
@ovflowd
Copy link
Member

ovflowd commented Jul 3, 2023

I'm transferring this to @nodejs/build as this is a CloudFlare configuration issue.

@richardlau
Copy link
Member

The tricky part is finding the legacy reason for why adding a wildcard in the first place. I can look around a bit.

@jbergstroem I don't suppose you ever found out why the wildcard was added?

@jbergstroem
Copy link
Member

The tricky part is finding the legacy reason for why adding a wildcard in the first place. I can look around a bit.

@jbergstroem I don't suppose you ever found out why the wildcard was added?

Unfortunately, no.

@richardlau
Copy link
Member

I've tried searches on https://github.com/nodejs/build and https://github.com/nodejs/iojs.org but couldn't find anything indicating why we have the wildcard CNAME entry for nodejs.org. In the absence of any evidence as to what it was for, I'm leaning towards removing it and seeing if anyone notices/complains.

@MoLow
Copy link
Member

MoLow commented Jul 3, 2023

I think we discussed in the TSC meeting adding a 301 redirect rule to all undefined DNS records to just redirect them to www.nodejs.org. AFAIK cloudflare has this built-in

@richardlau
Copy link
Member

Actually I think I may have a theory... in https://github.com/nodejs/build/blob/main/ansible/www-standalone/resources/config/nodejs.org?plain=1 we have a number of subdomains being redirected in nginx, e.g. docs.nodejs.org

server_name doc.nodejs.org docs.nodejs.org;
that we do not have explicit CNAME entries for. So we should probably first add explicit CNAME entries for those subdomains before removing the wildcard so that those redirects continue to work. Some of these could be turned into Cloudflare rules.

@targos
Copy link
Member

targos commented Jul 7, 2023

We found out yesterday that a few subdomains are (ab)used to directly access our server: registry.nodejs.org (our old friend, the broken Artifactory setup) capacitacioni-release.nodejs.org kdxwif.cn.nodejs.org sticky.nodejs.org shaikon.com.nodejs.org.
Removing the wildcard should help to reduce load issues on the server.

@targos
Copy link
Member

targos commented Jul 12, 2023

List of server_name (based on files in ansible/www-standalone/resources/config) that are not explicitly defined in Cloudflare DNS:

  • benchmarking.nodejs.org
  • doc.nodejs.org
  • docs.nodejs.org
  • api.nodejs.org
  • dist.nodejs.org
  • blog.nodejs.org

@richardlau
Copy link
Member

  • benchmarking.nodejs.org

I think we used to have a CNAME for this but it was removed #2485

@richardlau
Copy link
Member

I've added CNAME entries for everything in #3404 (comment).

I've just removed the * CNAME entry. FTR it looked like this:
image

@richardlau
Copy link
Member

It looks like enabling proxy on blog.nodejs.org breaks test/internet/test-dns.js: nodejs/node#48868
dns.resolveCname() is returning ENODATA for any of our proxied CNAME entries.

We did not have proxy enabled on the now removed *.nodejs.org CNAME entry that used to catch blog.nodejs.org. I've turned off proxy status just for blog.nodejs.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants