Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wrk on the benchmark machine #955

Closed
joyeecheung opened this issue Oct 30, 2017 · 3 comments
Closed

Install wrk on the benchmark machine #955

joyeecheung opened this issue Oct 30, 2017 · 3 comments

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Oct 30, 2017

Hi, it appears that the benchmark machine does not have wrk or autocannon installed so right now it does not produce meaningful results on the HTTP benchmarks (See: nodejs/node#16557). I have seen #821 (comment) but have not figured out how/where to update the ansible scripts for the benchmark CI machine, I guess alternatively one would need to ssh to that server and manually install the dependencies? Right now I would prefer using wrk over autocannon, so the things needs to be done are basically equivalent to:

apt-get install wrk

Let me know if there are things that I can help with.

@maclover7
Copy link
Contributor

ping -- has this been done?

@maclover7
Copy link
Contributor

Ref #868, looks like no Ansible playbook yet for benchmark machines. I am more than happy to help mentor and get this done if that helps at all, I've been doing a lot recently with the Ansible scripts :)

@mhdawson
Copy link
Member

@maclover7 it would be great if you could help get the ansible scripts created.

In the end I manually added wrk so closing this issue.

maclover7 added a commit to maclover7/build that referenced this issue May 31, 2018
maclover7 added a commit that referenced this issue Jun 1, 2018
Fixes: #821
Fixes: #955
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants