Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: add node-test-commit-pre #1004

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

All actions run before pending post-build-status-update job is run. My
thought is that node-test-commit sub jobs will curl from master, and
then pipe to bash.

All actions run before pending post-build-status-update job is run. My
thought is that node-test-commit sub jobs will `curl` from master, and
then pipe to bash.
refack

This comment was marked as off-topic.

@refack
Copy link
Contributor

refack commented Nov 21, 2017

👍 even if we don't curl it in, it's great to have this in a visible place.

@mhdawson
Copy link
Member

Instead of curl, my first thought would be that we'd clone the build repo at the start of each job and then can run the scripts directly.

Either way seems like a good first step for pulling some logic out of the jenkins config and into git where we can more easily track changes.

mhdawson

This comment was marked as off-topic.

maclover7 added a commit that referenced this pull request Nov 22, 2017
All actions run before pending post-build-status-update job is run. My
thought is that node-test-commit sub jobs will `curl` from master, and
then pipe to bash.

PR-URL: #1004
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@maclover7
Copy link
Contributor Author

Landed in 2e05d83

@maclover7 maclover7 closed this Nov 22, 2017
@maclover7 maclover7 deleted the jm-ntc-pre branch November 22, 2017 18:07
@refack
Copy link
Contributor

refack commented Nov 22, 2017

I rolled the change back for node-test-commit-linux-linked it was failing to generate env.properties so job were failing. https://ci.nodejs.org/job/node-test-commit-linux-linked/295/nodes=ubuntu1604_sharedlibs_debug_x64/console

P.S. I was sure node-test-commit-linux-linked was not in the multijob 🤔 yet

@rvagg
Copy link
Member

rvagg commented Nov 23, 2017

that's because I had some custom work in there for node-test-commit-linux-linked to solve a problem related to status posting, the addition and explanation is shown in this comment: nodejs/node#17151 (comment)

I could pull that into a separate script and we'd be back to status quo.

Re curl vs git I like the idea of using git cause there's a bunch more things we could pull into it, we could replace most (or all?) of our jenkins scripts with scripts in this repo if we did a clone first.

@maclover7 maclover7 self-assigned this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants