Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve security.txt file from the static directory #1181

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

MarcinHoppe
Copy link
Contributor

The URLs are recommended by the security.txt spec available at https://securitytxt.org.

The security.txt file was added to the static directory in a separate PR: nodejs/nodejs.org#1589.

The URLs are recommended by the security.txt spec
available at https://securitytxt.org.

The security.txt file was added to the static directory
in a separate PR in the nodejs/nodejs.org repo.
lpinca

This comment was marked as off-topic.

@MarcinHoppe MarcinHoppe changed the title Service security.txt file from the static directory Serve security.txt file from the static directory Mar 14, 2018
ChALkeR

This comment was marked as off-topic.

This change better reflects the intent of the specification.
vdeturckheim

This comment was marked as off-topic.

@ChALkeR
Copy link
Member

ChALkeR commented Mar 15, 2018

👍, the logic here looks good to me now.

Not pressing the «review» button as I don't feel confident enough reviewing changes in this repo (also, I have not tested this change) — so let's wait for someone from @nodejs/build WG to approve this.

gibfahn

This comment was marked as off-topic.

@gibfahn gibfahn requested a review from rvagg March 15, 2018 13:59
@gibfahn
Copy link
Member

gibfahn commented Mar 15, 2018

Needs a review from someone who has looked at these files recently, so @rvagg (or anyone else in @nodejs/build who has).

@MarcinHoppe
Copy link
Contributor Author

MarcinHoppe commented Mar 22, 2018

@nodejs/build is there any way we can move this forward? The security.txt is already in the Website content but its usefulness will be little if we don't put it in a well known location.

Let me know if there's anything I can do to complete this change.

@gibfahn
Copy link
Member

gibfahn commented Mar 22, 2018

@nodejs/build is there any way we can move this forward?

Just needs more build members to look at it. I'll ping some people.

@rvagg
Copy link
Member

rvagg commented Mar 23, 2018

fine by me

@rvagg rvagg merged commit ef4b386 into nodejs:master Mar 23, 2018
@rvagg
Copy link
Member

rvagg commented Mar 23, 2018

live now

@MarcinHoppe MarcinHoppe deleted the security-txt branch March 23, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants