Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create VersionSelectorScript.md #1599

Closed
wants to merge 1 commit into from
Closed

Create VersionSelectorScript.md #1599

wants to merge 1 commit into from

Conversation

tiagorvmartins
Copy link

First version of the documentation showing the list of compiler versions used to build each node version on each platform

First version of the documentation showing the list of compiler versions used to build each node version on each platform
@tiagorvmartins tiagorvmartins changed the title Create VersionSelectorScript.groovy Create VersionSelectorScript.md Nov 23, 2018
@rvagg
Copy link
Member

rvagg commented Nov 24, 2018

@tiagorvmartins I wonder if you could use my script in #1522 (comment) to make this automatically? I don't really like that this is manual and will need to be edited in parallel with VersionSelectorScript.groovy and it'd be nice to have an easy way for this to be generated and updated—automatic would be best but I don't have any bright ideas for achieving that yet.

I have the same problem with a NODE_MODULE_VERSION registry I'm trying to make @ nodejs/node#24114. Where parallel documentation that isn't integrated into the single .json file is going to get out of sync really easily. For that case I'm going to put descriptive metadata straight into the .json file so you're forced to see and edit it if you're touching the file.

@refack
Copy link
Contributor

refack commented Nov 24, 2018

I don't really like that this is manual and will need to be edited in parallel with VersionSelectorScript.groovy and it'd be nice to have an easy way for this to be generated and updated—automatic would be best but I don't have any bright ideas for achieving that yet.

The problem I asked @tiagorvmartins to help solve, is to have some sort of human readable documentations.
We could refactor VersionSelectorScript.groovy to include all this info, but there is still several gaps, like which compiler version each platforms uses, and what it used for test and what is used for release.

@sam-github
Copy link
Contributor

Cleaning up stalled PRs, they can be reopened if necessary.

Also, I don't see this as maintainable. It duplicates the actual config in .groovy, and the painstakingly maintained BUILDING.md in nodejs/node.

@sam-github sam-github closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants