-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add python3-pip to ubuntu.Dockerfiles #1679
Conversation
https://pypi.org/project/tap2junit Says that tap2junit is compatible with legacy Python but says nothing about Python 3 compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @nodejs/build |
@refack @rvagg @richardlau Is this PR going in the right direction or should I close it? |
I have no idea @cclauss, you tell me, what does this even do? What does it mean to have both |
Python 2 and Python 3 have two separate copies of pip. These are usually called pip2 and pip3 but not always so the safe approach is to do python2 -m pip and python3 -m pip to ensure that you are getting the pip that corresponds to the Python that you want to use. TL;DR They maintain separate "site-packages" directories so that a module like tap2junit needs to be installed into both if we want that module to be accessible to both Py2 and Py3. On my machine I get:
If I do import tap2junit in a Python 2 script, I will get the module from the first site-package and if I run the exact same code on a Python 3 interpreter, I will get the module from the second. We will need to have a similar setup on all boxes where we want to test both Pythons. |
should be deployed across all the containers now |
https://pypi.org/project/tap2junit says that tap2junit is compatible with legacy Python but says nothing about Python 3 compatibility. Related to #1674