-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipelines: add lint-py to linter pipeline #1745
Conversation
4f535f4
to
2e75cd2
Compare
Oh and you've mispelled |
562f2b3
to
ddad8de
Compare
ddad8de
to
024d423
Compare
New CI for master - https://ci.nodejs.org/job/node-linter/3048/console |
* Compatibility changes to github-bot already shipped
024d423
to
3369f2c
Compare
v6.x Linter: https://ci.nodejs.org/job/node-linter/3116/ ✔️ |
/ping @nodejs/jenkins-admins to see if anyone else wants to take a look at this |
This is linting on both Python 2 and 3? |
Yes for versions of Node.js > 11. |
@richardlau do you understand enough to land this, or call it stale and close it? |
These changes have already been made to the pipelines in question* so this PR is basically merging those changes to the backup jenkinsfile in this repository. We can have a separate discussion about whether having jenkinsfiles in SCM and not using those directly in the Jenkins jobs is a good idea or not but for now I'll just merge this in so the files here matches the scripts in the jobs. * We haven't been running the |
fixes: #1631
example output (
master
):v10.x-staging
:v8.x-staging
- https://ci.nodejs.org/job/node-linter/3040/console