Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add new AIX7.1 machines to CI #2056

Merged
merged 10 commits into from
Dec 7, 2019
Merged

Conversation

AshCripps
Copy link
Member

This is a draft pass at adding new AIX72 to our test ci.

Ive edited the anisble to install the packages that use to be done manually.

One machine is commented out as I dont have access atm and so its not currently ansibled yet

Finally Ive cleaned up and edited the manual steps .md with additions needed and ive also split it into 6.1 and 7.2 install steps as both have some differences.

These machines aren't ready yet as I dont have CI access so they are missing the jenkins secret.

@AshCripps AshCripps force-pushed the add-new-aix branch 2 times, most recently from 2a9d176 to bf587f0 Compare November 29, 2019 14:53
@AshCripps AshCripps changed the title [WIP] ansible: add new AIX72 machines to CI [WIP] ansible: add new AIX7.1 machines to CI Dec 3, 2019
@AshCripps AshCripps changed the title [WIP] ansible: add new AIX7.1 machines to CI ansible: add new AIX7.1 machines to CI Dec 4, 2019
@AshCripps
Copy link
Member Author

This is now good to go.

We are only adding the AIX7.1 machines currently as we are still waiting on confirmation of how many 7.2 machines we will get.

There are two test machines and one release machines

The next step will be connecting them to the CI

@AshCripps
Copy link
Member Author

@sam-github Addressed your comments PTAL

@sam-github
Copy link
Contributor

@richardlau PTAL -- I think this is purely additive, and mostly docs, so it should be possible to land without disturbing any existing builds.

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Left some comments, mainly about whether some of the manual setup could be ansibled (just to reduce the burden if the machines have to be reimaged).

AshCripps added 10 commits December 7, 2019 12:49
also update the ansible vars file for missing packages that used to
added manually
This commit edits select-compiler.sh to allow for the different LIBPATH
that needs to be set for AIX 7.1 to build properly
Switched to just aix7.1 machines as 7.2 are not ready
@sam-github sam-github merged commit 8592b5f into nodejs:master Dec 7, 2019
@AshCripps AshCripps deleted the add-new-aix branch December 10, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants