Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: set JOBS to 4 for AIX #2067

Merged
merged 1 commit into from
Nov 27, 2019
Merged

ansible: set JOBS to 4 for AIX #2067

merged 1 commit into from
Nov 27, 2019

Conversation

sam-github
Copy link
Contributor

Some of the builds were taking the 20 CPUS to mean run with JOBS=20, but
the machines don't have enough memory to run at that kind of build
concurrency. Throttle to 4. Some jobs were doing this already, but by
setting it in the global env, it should be inherited by all jobs.

Some of the builds were taking the 20 CPUS to mean run with JOBS=20, but
the machines don't have enough memory to run at that kind of build
concurrency. Throttle to 4. Some jobs were doing this already, but by
setting it in the global env, it should be inherited by all jobs.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -15,6 +15,7 @@ start )
export NODE_TEST_DIR=$HOME/tmp; \
export NODE_COMMON_PIPE="$HOME/test.pipe"; \
export OSTYPE=AIX61; \
export JOBS=4; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.nodejs.org/job/node-test-commit-aix/ has:

export JOBS=5

I'm okay with 5 or 4.

@richardlau
Copy link
Member

For some further background see nodejs/node#27186 (comment).

@sam-github sam-github merged commit 4671676 into nodejs:master Nov 27, 2019
@sam-github sam-github deleted the aix-jobs-4 branch November 27, 2019 23:19
@richardlau
Copy link
Member

@AshCripps @sam-github Do we also need to set JOBS for the AIX 7.1/7.2 systems, which use ansible/roles/jenkins-worker/templates/aix.rc2.j2?

@sam-github
Copy link
Contributor Author

@richardlau This PR was triggered by builds failing with out of memory, I don't think we need to make the changes anywhere that the problem is not being seen. There isn't any relationship between AIX7 mem and cpu provisioning, and AIX6.1, different machines, different host, different resource amounts allocated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants