Reprovision s390x machines

[AshCripps]

READY FOR REVIEW

This is to replace the current s390x machines with 5 machines in the new datacentre - 1 release, 4 test

See: #2080

[AshCripps]

Part of this PR is to update every reference from rhel72 to rhel7 because its just plain wrong otherwise, Let me know if ive missed anything or if thats likely to cause problems.

[richardlau]

Part of this PR is to update every reference from rhel72 to rhel7 because its just plain wrong otherwise, Let me know if ive missed anything or if thats likely to cause problems.

We'd need to go through all of the jobs on Jenkins (both test and release) and update (which we'll have to do regardless if we're adding new machine names (i.e. the switch from linuxonecc to ibm as the provider) rather than replacing the existing ones).

SelectCompiler.sh and VersionSelectorScript.groovy should be okay as they just match on s390x:

build/jenkins/scripts/select-compiler.sh

Line 21 in 39cacfe

*s390x* ) SELECT_ARCH=S390X ;;

build/jenkins/scripts/VersionSelectorScript.groovy

Line 59 in 39cacfe

[ /s390x/, anyType, lt(6) ],

[AshCripps]

all five machines are ansibled and this pr is ready to be reviewed

[sam-github]

a couple small comments, this is close to landing.

[sam-github]

@nodejs/build-infra This requires firewall changes. There is some urgency to this, it would be helpful to have it done in the next few days, to give us time to test the replacements. We may have the existing machines shut off (along with their datacentre) by January 1st 2020 (though I hope that won't happen so quickly).

[sam-github]

@richardlau / @nodejs/build-wg Any reason for me not to squash merge this right now? It doesn't touch select-compiler.sh or the groovy files, just ansible, so I can't see it interfering with the ongoing security release, it looks entirely benign.

[richardlau]

@richardlau / @nodejs/build-wg Any reason for me not to squash merge this right now? It doesn't touch select-compiler.sh or the groovy files, just ansible, so I can't see it interfering with the ongoing security release, it looks entirely benign.

No objections from me.

cc @nodejs/build

[mhdawson]

@sam-github IPs added to firewalls.