ansible: add 10.15 macs #2189

AshCripps · 2020-02-19T19:59:41Z

Its finally here 🎉

Currently a draft as ive only had time to add one machine and shave a couple hairy yaks

sam-github

LGTM, though I understand its WIP. There was more churn in inventory.yml than I expected, does it include some unrelated changes, or is it some cleanups while you are there?

ansible/roles/java-base/tasks/main.yml

AshCripps · 2020-02-20T14:27:11Z

ansible/roles/java-base/tasks/main.yml

+- name: install java tap (macOS)
+  become_user: administrator
+  when: java.rc > 0 and os|startswith("macos")
+  homebrew_tap:
+        name: AdoptOpenJDK/openjdk
+        state: present


This is effectively duplicated code from

build/ansible/roles/package-upgrade/tasks/partials/brew.yml

Lines 36 to 39 in 1cbb6cf

- name: Add AdoptOpenJDK Java Repo

become_user: administrator

homebrew_tap:

name: AdoptOpenJDK/openjdk

but I needed this change to get be able install the openjdk, even though ansible tells me the task ive linked to ran ok. @nodejs/build anyone have an ideas/experience as to why this code works in one place but not another?

So partials/brew.yml ran and you saw it running homebrew_tap for the AdoptOpenJDK/openjdk cask and the next task, which installs the package, failed until you yanked the homebrew_tap into this position? It's not an ordering problem is it, partials/brew.yml ran before this didn't it?

Yeah I can see partials/brew,yml run but it reports nothing changed under add AdoptOpenJDK repo it wasnt until I add the tap to this position that anything happened

also tidied up the nearform section and put it in order with the rest of the document

AshCripps · 2020-02-21T17:26:53Z

Created the jenkins agents - https://ci.nodejs.org/label/osx1015/

Will need someone to create the release agent for me.

@nodejs/build-infra can someone add the IPs to the respective CI firewalls please?

AshCripps · 2020-02-21T18:06:52Z

Currently seeing these test failures on one of the test machines:

=== release test-dgram-connect-send-empty-array ===
Path: parallel/test-dgram-connect-send-empty-array
Command: out/Release/node /Users/iojs/node/test/parallel/test-dgram-connect-send-empty-array.js
--- TIMEOUT ---
=== release test-dgram-connect-send-empty-buffer ===
Path: parallel/test-dgram-connect-send-empty-buffer
Command: out/Release/node /Users/iojs/node/test/parallel/test-dgram-connect-send-empty-buffer.js
--- TIMEOUT ---
=== release test-dgram-connect-send-empty-packet ===
Path: parallel/test-dgram-connect-send-empty-packet
Command: out/Release/node /Users/iojs/node/test/parallel/test-dgram-connect-send-empty-packet.js
--- TIMEOUT ---
=== release test-dgram-send-empty-array ===
Path: parallel/test-dgram-send-empty-array
Command: out/Release/node /Users/iojs/node/test/parallel/test-dgram-send-empty-array.js
--- TIMEOUT ---
=== release test-dgram-send-empty-buffer ===
Path: parallel/test-dgram-send-empty-buffer
Command: out/Release/node /Users/iojs/node/test/parallel/test-dgram-send-empty-buffer.js
--- TIMEOUT ---
=== release test-dgram-send-empty-packet ===
Path: parallel/test-dgram-send-empty-packet
Command: out/Release/node /Users/iojs/node/test/parallel/test-dgram-send-empty-packet.js
--- TIMEOUT ---
[11:32|% 100|+ 2913|-   6]: Done

Im assuming these are errors due to some mising network settings?

sam-github · 2020-02-21T18:08:34Z

Perhaps a one-time run of https://github.com/nodejs/node/blob/master/tools/macos-firewall.sh is needed?

AshCripps · 2020-02-24T11:03:59Z

Done some digging, looks like this is a known catalina issue - nodejs/node#30030 which Apple has not fixed yet

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: nodejs#30030 Refs: nodejs/build#2189 (comment)

sam-github · 2020-02-24T18:36:48Z

@AshCripps can you try nodejs/node#31936 and see if the updating of expected status fixes this for you?

rvagg

sgtm, do I take it from this that release-nearform-macos10.15-x64-1 is a thing and we could start switching releases over to it soon?

AshCripps · 2020-02-25T13:14:59Z

sgtm, do I take it from this that release-nearform-macos10.15-x64-1 is a thing and we could start switching releases over to it soon?

yes @rvagg there is a release machine setup, just waiting on its IP to be added to the firewall - same as the test machines.

need nodejs/node#31936 to land on all lines to stop the constant test failures

mhdawson

LGTM

mhdawson · 2020-02-25T19:47:24Z

@AshCripps firewall entries added for both test and release.

sam-github · 2020-02-25T20:29:23Z

@AshCripps the machine is in ci-release and is connected: https://ci-release.nodejs.org/computer/release-nearform-macos10.15-x64-1/ (for those with visibility).

I had trouble getting in by ssh, but could you add the release team ssh key to .ssh/authorized_keys?

ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDFCAmx+ldk/UyR0x0xrsvdORi59uGPdErcitIjjBZRFnE87MGIZtmsZIqGogxgEc1A1t86/eCCvL7we31iE0sF71Stx17ZxTKuo/VCTACeg1GRd3/wdVHXphAss5sBYyV/T7hcGq7aq4PsrloAUhLfmivXAG0ALhWG3AAv4AnVWaa372XWIoYqiDQCL5uEClEP/A95CdqRrbYY4bWZRR0eZMgWhX5Npy1tThuA+p0+mmvY6AGHpTW33+d8qfGwubv1tPvV7G+vQ2cjlQTWd+NfnmzoOGUIcXGZ8yhfdXwFeNdduyIalL1Jm2WxbyStQ2SFXIFgSK+tjVEMGC4H+N8oOd2jbZYANxkCDugbaP3OSYwOYyUGnMJztt1g8oemGN9QtY7GGssuOxeUrYXGAYpD7BEqX7Jh2v5zd7Uvl7W60oYwikTtJkIEclEKOE2dEhHwDrZbt3KhF+VSjhaZdfrt+fMm3qQMGPdx16lT/IxHUm825A6Nzbmtm0H8yczXGnhG59w3bGAcUxD7OqZPmQaQnw1Abba0BBbsjj28KdkUddm91DjRzJCnXtJ6DLJxxn40MISE/loy/yvCLb3HCvhgo55hB4C0XCeMfbVYGwbx3TrX1en89aZ96s9EAMATZk4S+47cnx3jfy/5CP6ms4UsvGCelMPhgdqGBG/xOr7kKw== release@build.nodejs.org

^--- check for inadvertent cut-n-paste line breaks! should be one line. That's the public key, it has no sec significance, but once its there any release team member can ssh in (I assume, not a member myself).

At that point, I think @rvagg could dry-run notarization.

AshCripps · 2020-02-25T20:38:51Z

@sam-github added, can you try now?

sam-github · 2020-02-25T20:42:47Z

@AshCripps no, I can't try, only these people have the private key that goes with that public one :-)

I'll open an issue to get you enough access to do add the machines to test CI.

sam-github · 2020-02-25T20:48:27Z

@AshCripps you are already a https://github.com/nodejs/build#jenkins-admins, so, the thing to do now is to create a node-test-commit-osx-ashcripps job by cloning the base job. Once you have the clone, go to the machine selection part, and find the osx1015 label that the 3 new test machines have, and click it. At that point, you should be able trigger a run of the job against nodejs/master from the Jenkins UI, and see that they fail on the tests that are skipped by nodejs/node#31936, or you could even test my specific branch from that PR, if you want, to confirm the build is green. Then, once we can see the build is green in your cloned job, we are good to select the osx1015 machines to add them to CI in the regular node-test-commit-osx... and the test side of this is done.

After that, its mop-up: adding the label to the release builds, the v8 builds, citgm.... etc.

AshCripps · 2020-02-26T13:25:34Z

build of master: https://ci.nodejs.org/job/node-test-commit-osx-AshCripps/1/nodes=osx1015/

build of @sam-github's PR: https://ci.nodejs.org/job/node-test-commit-osx-AshCripps/5/nodes=osx1015/

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

AshCripps · 2020-02-26T16:38:24Z

oops @rvagg the release machine needs this doing to it - #1393. I dont have the access nessacary to do it I dont think

AshCripps · 2020-02-27T13:31:54Z

Added the machines to node-test-commit and all citgm jobs

Tried adding it to a libuv job but I get an xcodebuild error which is weird as xcodebuild isnt on any of the currently working machines: https://ci.nodejs.org/job/libuv-test-commit-osx-AshCripps/1/

Any ideas @richardlau?

richardlau · 2020-02-27T14:13:01Z

It’s probably related to #2172 and the version of gyp being used being old. gyp in nodejs/node and nodejs/node-gyp were updated to cope with double digit versions of xcode.

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

* ansible: Add newer versions of macOS * ansible: add macos10.15 release machine * ansible: fix openjdk download on mac * ansible: add 3 test machines also tidied up the nearform section and put it in order with the rest of the document * ansible: tweak macos install

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: nodejs#30030 Refs: nodejs/build#2189 (comment) PR-URL: nodejs#31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: #30030 Refs: nodejs/build#2189 (comment) PR-URL: #31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> PR-URL: #32146 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

AshCripps added 2 commits February 19, 2020 15:43

ansible: Add newer versions of macOS

bf65dae

ansible: add macos10.15 release machine

54e9439

sam-github approved these changes Feb 20, 2020

View reviewed changes

ansible/roles/java-base/tasks/main.yml Outdated Show resolved Hide resolved

ansible: fix openjdk download on mac

18dac80

AshCripps commented Feb 20, 2020

View reviewed changes

AshCripps added 2 commits February 20, 2020 17:40

ansible: add 3 test machines

5886275

also tidied up the nearform section and put it in order with the rest of the document

ansible: tweak macos install

aa61f03

sam-github added a commit to sam-github/node that referenced this pull request Feb 24, 2020

test: mark empty udp tests flaky on OS X

e8667bb

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: nodejs#30030 Refs: nodejs/build#2189 (comment)

sam-github mentioned this pull request Feb 24, 2020

test: mark empty udp tests flaky on OS X nodejs/node#31936

Closed

4 tasks

rvagg approved these changes Feb 25, 2020

View reviewed changes

mhdawson approved these changes Feb 25, 2020

View reviewed changes

AshCripps changed the title ~~[WIP] ansible: add 10.15 macs~~ ansible: add 10.15 macs Feb 26, 2020

AshCripps merged commit 1b222ff into nodejs:master Feb 26, 2020

AshCripps deleted the add-new-mac branch March 4, 2020 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ansible: add 10.15 macs #2189

ansible: add 10.15 macs #2189

AshCripps commented Feb 19, 2020 •

edited

Loading

sam-github left a comment

AshCripps Feb 20, 2020 •

edited

Loading

rvagg Feb 25, 2020

AshCripps Feb 25, 2020

AshCripps commented Feb 21, 2020

AshCripps commented Feb 21, 2020

sam-github commented Feb 21, 2020

AshCripps commented Feb 24, 2020

sam-github commented Feb 24, 2020

rvagg left a comment

AshCripps commented Feb 25, 2020 •

edited

Loading

mhdawson left a comment

mhdawson commented Feb 25, 2020

sam-github commented Feb 25, 2020

AshCripps commented Feb 25, 2020

sam-github commented Feb 25, 2020

sam-github commented Feb 25, 2020

AshCripps commented Feb 26, 2020 •

edited

Loading

AshCripps commented Feb 26, 2020

AshCripps commented Feb 27, 2020

richardlau commented Feb 27, 2020

	- name: Add AdoptOpenJDK Java Repo
	become_user: administrator
	homebrew_tap:
	name: AdoptOpenJDK/openjdk

ansible: add 10.15 macs #2189

ansible: add 10.15 macs #2189

Conversation

AshCripps commented Feb 19, 2020 • edited Loading

sam-github left a comment

Choose a reason for hiding this comment

AshCripps Feb 20, 2020 • edited Loading

Choose a reason for hiding this comment

rvagg Feb 25, 2020

Choose a reason for hiding this comment

AshCripps Feb 25, 2020

Choose a reason for hiding this comment

AshCripps commented Feb 21, 2020

AshCripps commented Feb 21, 2020

sam-github commented Feb 21, 2020

AshCripps commented Feb 24, 2020

sam-github commented Feb 24, 2020

rvagg left a comment

Choose a reason for hiding this comment

AshCripps commented Feb 25, 2020 • edited Loading

mhdawson left a comment

Choose a reason for hiding this comment

mhdawson commented Feb 25, 2020

sam-github commented Feb 25, 2020

AshCripps commented Feb 25, 2020

sam-github commented Feb 25, 2020

sam-github commented Feb 25, 2020

AshCripps commented Feb 26, 2020 • edited Loading

AshCripps commented Feb 26, 2020

AshCripps commented Feb 27, 2020

richardlau commented Feb 27, 2020

AshCripps commented Feb 19, 2020 •

edited

Loading

AshCripps Feb 20, 2020 •

edited

Loading

AshCripps commented Feb 25, 2020 •

edited

Loading

AshCripps commented Feb 26, 2020 •

edited

Loading