Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: fix compiler selection for ppcle Linux #2285

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

richardlau
Copy link
Member

#2262 mistakenly added a
duplicated case that prevented the previously existing logic from
being executed. Merge the two centos cases for ppcle Linux.

Refs: nodejs/node#32768 (comment)

nodejs#2262 mistakenly added a
duplicated case that prevented the previously existing logic from
being executed. Merge the two centos cases for ppcle Linux.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
@richardlau
Copy link
Member Author

richardlau commented Apr 10, 2020

Test builds:
v10.x: https://ci.nodejs.org/job/node-test-commit-plinux-richardlau/1/
We don't have compiler versions output in v10.x (we've only just added that to master) but it looks like the job has picked devtoolset6 (and no warnings about the compiler level).

master: https://ci.nodejs.org/job/node-test-commit-plinux-richardlau/2/

20:50:52 Detected C++ compiler (CXX=ccache ppc64le-redhat-linux-g++) version: 8.3.1
20:50:52 Detected C compiler (CC=ccache ppc64le-redhat-linux-gcc) version: 8.3.1

Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@sam-github sam-github merged commit 2e2c1e9 into nodejs:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants