-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: update rsnapshot configuration #2637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can we add /etc/ off nodejs.org too? way more useful stuff going on in there than even the CI machines that we'd be sad to lose .. mostly we'd cross our fingers that we've kept ansible in sync if we had to restore that but I don't have great faith in that. |
Sure, that'd be
(I'll sleep first because the file is tab sensitive so I'd rather do that in front of a proper computer with a proper editor rather than try to get it right on a tablet through the GitHub web interface.) |
Added a backup for |
Sync `rsnapshot.conf` with what is currently running on the backup server: `ssh backup cat /opt/local/etc/rsnapshot.conf > rsnapshot.conf`
Adds backup of `/etc/` to `etc/<server>/`. The existing backups of `/var/lib/jenkins/` are left in `<server>/` to avoid creating new inodes for unchanged files/directories.
I've deployed the changes now and they took effect for the most recent backup. before (previous backup)
after
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The first commit updates the copy of
rsnapshot.conf
we have in this repository with what is currently deployed on the backup server, taken via:(FWIW it looks like we no longer take mysql dumps from the benchmark machine -- I think this was part of #2485 with the de-chartering of the benchmarking WG (nodejs/TSC#955).)
The second commit is a proposed change (not yet made) to also backup
/etc
from both CI servers. This will include nginx and telegraf (for grafana) configuration. Currently the whole of/etc
is around 7mb on each server. I've left the existing Jenkins backup where it is to not disturb the diffs to the existing backups since those are large. We would end up with a directory structure for each backup (e.g. under/backup/periodic/daily.0
):ci.nodejs.org
/var/lib/jenkins
from ci.nodejs.orgci-release.nodejs.org
/var/lib/jenkins
from ci-release.nodejs.orgetc/ci.nodejs.org
/etc
from ci.nodejs.orgetc/ci-release.nodejs.org
/etc
from ci-release.nodejs.orgetc/nodejs.org
/etc
from (direct.)nodejs.orgcc @nodejs/build-infra