Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add MoLow to test #3161

Merged
merged 1 commit into from
Mar 22, 2023
Merged

meta: add MoLow to test #3161

merged 1 commit into from
Mar 22, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jan 26, 2023

I am interested to join the Build WG, for the purpose of eventually getting familiar enough with the infrastructure so that I can help handle issues.
CC @richardlau

@mhdawson
Copy link
Member

mhdawson commented Feb 2, 2023

+1 from me.

I've talked to another TSC member who is confortable with adding @MoLow based on his contributions. That same TSC member also reached out to a long time Node.js contributor that I also trust who confirmed he would be a good build team member.

With that I'm +1 to adding @MoLow

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sxa
Copy link
Member

sxa commented Feb 8, 2023

Discussed at build meeting. Next step will be to schedule an onboarding session

@MoLow
Copy link
Member Author

MoLow commented Feb 18, 2023

@nodejs/build what would be the next steps?

@mhdawson
Copy link
Member

@MoLow we need a volunteer to onboard you. I'm hoping somebody else volunteers but nobody does I'll see if I can find a time next week.

@targos
Copy link
Member

targos commented Feb 22, 2023

I was never really onboarded, so would be interested to join the session.

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2023

I'm on holiday for the next week and a half but maybe it makes sense to set a time. I may not be the best person to onboard, but I'll do my best :)

Does March 22 at 11 ET work for you two?

@MoLow
Copy link
Member Author

MoLow commented Mar 2, 2023

you mean 11 am right?
https://www.worldtimebuddy.com/?qm=1&lid=5,281184,294117&h=5&date=2023-3-22&sln=11-12&hf=1
if so that works for me

@mhdawson
Copy link
Member

mhdawson commented Mar 3, 2023

@MoLow in advance can you complete the steps outline as "do before" in https://github.com/nodejs/build/blob/main/ONBOARDING.md#onboarding-to-build-test-issue-checklist

@targos
Copy link
Member

targos commented Mar 4, 2023

works for me too

@mhdawson
Copy link
Member

Sent invite. @MoLow, @targos both of you should have received it.

@mhdawson
Copy link
Member

Completed the onboarding today, landing.

@mhdawson mhdawson merged commit f4edc7b into nodejs:main Mar 22, 2023
@MoLow MoLow deleted the add-molow-to-test branch March 22, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants