-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: remove old github.com ssh key from known_hosts #3256
Conversation
Tested with:
It seems to have worked fine! |
Just ran it on all (available) hosts |
@targos did that include running on the docker maines along the linst of #3254 (comment)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since it worked :)
No, I wasn't aware of that command and just spent some time updating a lot of docker containers manually... |
|
@targos thanks for taking the time/effort to do the manual updates, have you done them all? If not maybe we can split up the remaining ones? |
@targos I'm not sure we can run just that step in the EDIT: should have mentioned that since Richard is out, updating manually in the short term makes sense to me as you have already done/started. |
@mhdawson I don't know what are the remaining ones :) I started a new CI job here to monitor: https://ci.nodejs.org/job/node-test-pull-request/50600/ and updated test-digitalocean-ubuntu1804-x64-1 |
@targos thanks for all of your hard work. |
Fixed up a few more hosts as mentioned in #3254 |
Resumed @targos build here to see if there are more hosts that will fail - https://ci.nodejs.org/job/node-test-pull-request/50601/ |
fails in https://ci.nodejs.org/job/node-test-commit-linux-containered/36770/nodes=ubi81_sharedlibs_openssl111fips_x64/console |
I am rerunning |
This comment was marked as resolved.
This comment was marked as resolved.
Resumed again: https://ci.nodejs.org/job/node-test-pull-request/50602/ |
didn't seem to help: https://ci.nodejs.org/job/node-test-commit-linux-containered/36771/nodes=ubi81_sharedlibs_openssl111fips_x64/ |
See #3254 (comment) -- the containers are set up through a different set of Ansible tasks. I'm going to merge this PR and then work on a follow up to move the known_hosts for GitHub tasks to it's own role that will be called from both the jenkins-worker/create playbook and the docker-host playbook. |
Refs: https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
Refs: #3254
This is untested. I won't be in a position to run a playbook until Tuesday.