Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins,doc: update supported Visual Studio for v21 #3484

Merged
merged 2 commits into from
Oct 7, 2023
Merged

jenkins,doc: update supported Visual Studio for v21 #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6b110
jenkins,doc: update supported Visual Studio for v21
targos Sep 13, 2023
e383c44
skip release vs2022 on older lines
targos Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions doc/windows-visualstudio-supported-versions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,47 +10,41 @@ Supported versions for running the Node.js installer and executable as released.

| Node.js Version | Windows Version |
|-----------------|----------------------------|
| v16 | 10 / 2012 R2 |
| v18 | 10 / 2016 |
| v19 | 10 / 2016 |
| v20 | 10 / 2016 |
| v21 | 10 / 2016 |

## For building Node.js Core

Supported versions for building Node.js from source.

| Node.js Version | Visual Studio Version |
|-----------------|-------------------------------------|
| v16 | 2019 <sup>[1]</sup> |
| v18 | 2019 |
| v19 | 2019 |
| v20 | 2019 |
| v21 | 2022 |

## For building Node.js Addons

Supported versions for building Node.js addons. End-users should have one of these installed for building native modules.

| Node.js Version | Visual Studio Version |
|-----------------|-------------------------------------------|
| v16 | 2015, VCBT2015, 2017, 2019 |
| v18 | 2015, VCBT2015, 2017, 2019 |
| v19 | 2017, 2019 <sup>[2]</sup> |
| v20 | 2017, 2019 <sup>[2]</sup> |
| v20 | 2017, 2019 <sup>[1]</sup> |
| v21 | 2017, 2019, 2022 <sup>[1]</sup> |

## Official Releases

These versions are used to build the official releases.

| Node.js Version | Windows Version | Visual Studio Version |
|-----------------|-----------------|-----------------------|
| v16 | 2012 R2 | 2019 |
| v18 | 2012 R2 | 2019 |
| v19 | 2012 R2 | 2019 |
| v20 | 2012 R2 | 2019 |
| v21 | 2022 | 2022 |

## References

1. Support for Visual Studio 2017 was removed in v15.0.0.
- Pull Request: https://github.com/nodejs/node/pull/33694
2. Support for building addons with Visual Studio 2015 was removed in v19.0.0.
1. Support for building addons with Visual Studio 2015 was removed in v19.0.0.
- Pull Request: https://github.com/nodejs/node-gyp/pull/2746
3 changes: 3 additions & 0 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,12 @@ def buildExclusions = [
[ /vs2015/, releaseType, gte(16) ],
[ /vs2017/, releaseType, gte(16) ],
[ /vs2019-arm64/, releaseType, lt(20) ],
[ /vs2019/, releaseType, gte(21) ],
[ /vs2022/, releaseType, lt(21) ],
// VS versions supported to compile Node.js - also matches labels used by test runners
[ /vs2015(-\w+)?$/, testType, gte(16) ],
[ /vs2017(-\w+)?$/, testType, gte(16) ],
[ /vs2019/, testType, gte(21) ],
[ /vs2022(-\w+)?$/, testType, lt(20) ], // Temporarily compile Node v20+ on both VS2019 and VS2022
[ /vs2022-x86$/, testType, lt(20) ], // Temporarily compile Node v20+ arm64 and x86 on both VS2019 and VS2022
[ /vs2022-arm64$/, testType, lt(20) ],
Expand Down