Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the NODE_TEST_DIR env variable on Ubuntu 16.04 and 16.10 #785

Merged
merged 9 commits into from
Sep 11, 2017

Conversation

piccoloaiutante
Copy link
Member

This PR tries to adapt the previous #658 to the new ansible structure that we adopted recently.

Basically is adding an extra step for Ubuntu 16.04 and 16.10 to create the tmp directory used in NODE_TEST_DIR variable.

cc @jbergstroem @mcollina

mcollina

This comment was marked as off-topic.

@jbergstroem
Copy link
Member

any reason we don't do this for every setup?

@mcollina
Copy link
Member

mcollina commented Jul 9, 2017

The other setups already have that folder created.

@jbergstroem
Copy link
Member

@mcollina said:
The other setups already have that folder created.

Ah. We should probably move it to the jenkins role instead then.

@piccoloaiutante
Copy link
Member Author

@jbergstroem so creating another folder under ansible/roles/jenkins-worker/tasks/partials for this task and adding files only for ubuntu. Then adding this task to main.yml similarly to what has been done for tap2junit ?

@jbergstroem
Copy link
Member

@piccoloaiutante I would probably just add it to main.yml in the jenkins-worker role seeing how it's a oneliner all workers should be doing.

@piccoloaiutante
Copy link
Member Author

@jbergstroem should be good ok now.

MylesBorins

This comment was marked as off-topic.

MylesBorins

This comment was marked as off-topic.

gibfahn

This comment was marked as off-topic.

gibfahn

This comment was marked as off-topic.

gibfahn

This comment was marked as off-topic.

@gibfahn
Copy link
Member

gibfahn commented Sep 11, 2017

I think we're good to land this, it's been sitting for ages and it keeps causing issues with releases.

Of course merging this doesn't mean the tmp directories will magically come back unless someone reruns the playbook on the machines.

@gibfahn gibfahn merged commit 82d95d4 into nodejs:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants