Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-bot: add IPs of Jenkins workers #985

Merged
merged 3 commits into from
Nov 27, 2017
Merged

github-bot: add IPs of Jenkins workers #985

merged 3 commits into from
Nov 27, 2017

Commits on Nov 27, 2017

  1. github-bot: add IPs of Jenkins workers 

    Providing `$JENKINS_WORKER_IPS` environment variable at startup will
activate the whitelist implemented in the bot, validating who's allowed
to pushed Jenkins job updates as inline PR statuses on github.com.

Refs: nodejs/github-bot#142
PR-URL: nodejs#985
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @phillipj
    phillipj committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    632542a View commit details
    Browse the repository at this point in the history

  2. inventory: add github-bot reminder when changing Jenkins worker IPs 

    The github-bot has a whitelist of IPs that's allowed to push Jenkins
job status as inline PR status on github.com. Whenever we change our
Jenkins worker IPs, we should remember to update the bot's whitelist
as well.

PR-URL: nodejs#985
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @phillipj
    phillipj committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    32f4636 View commit details
    Browse the repository at this point in the history

  3. ansible: added todo to automate Jenkins worker IPs for github-bot 

    Instead of keeping the list of whitelisted Jenkins worker IPs up-to-date
manually, it would be ideal to automate that with a python script
instead.

Refs: nodejs#985 (comment)
PR-URL: nodejs#985
    @phillipj
    phillipj committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    5050016 View commit details
    Browse the repository at this point in the history