Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native tag to lookup.json for native modules #377

Closed
gibfahn opened this issue Mar 1, 2017 · 2 comments
Closed

Add native tag to lookup.json for native modules #377

gibfahn opened this issue Mar 1, 2017 · 2 comments
Assignees
@gibfahn

Comments

@gibfahn
Copy link
Member

gibfahn commented Mar 1, 2017

Now that #308 has landed, we should start adding tags for useful subsections of our tested modules.

The first one that comes to mind is a native tag for native modules.
@gibfahn gibfahn mentioned this issue Mar 1, 2017
Closed
@gibfahn gibfahn self-assigned this Mar 1, 2017
@richardlau
Copy link
Member

node-report would be one of those that should be tagged native.

gibfahn added a commit to gibfahn/citgm that referenced this issue Mar 1, 2017
@gibfahn
lookup: add "native" tag for native modules
d8eccac 
Fixes: nodejs#377
@gibfahn gibfahn mentioned this issue Mar 1, 2017
Merged
3 tasks
@gibfahn
Copy link
Member Author

gibfahn commented Mar 1, 2017

PR: #378

gibfahn added a commit to gibfahn/citgm that referenced this issue Mar 22, 2017
@gibfahn
lookup: add "native" tag for native modules
b285af5 
Fixes: nodejs#377
gibfahn added a commit to gibfahn/citgm that referenced this issue Apr 10, 2017
@gibfahn
lookup: add "native" tag for native modules
83438bf 
Fixes: nodejs#377
gibfahn added a commit that referenced this issue Apr 10, 2017
@gibfahn
lookup: add "native" tag for native modules
2b2e00a 
Fixes: #377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibfahn gibfahn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardlau @gibfahn