State of v16.4.0

[targos]

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1097/

[targos]

Fix for underscore: #873

[targos]

It looks like npm 7 doesn't like the @ in the prefix for pug: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/1097/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/pug_v3_0_2/

The command that fails is:

npm pack https://github.com/pugjs/pug/archive/pug@3.0.2.tar.gz

Edit: I confirm this command works in npm 6

[targos]

@nodejs/npm what do you think about the above error with npm pack?

[wraithgar]

This is happening because npm@7 is a little more strict about what it can pack. That tarball isn't an actual published package (published packages must have a name and version attribute). That tarball appears to be a "release" which is not the same thing. npm is assuming it is sourcing tarballs from something that acts like a registry, i.e. something that is going to have name and version attributes in its package.json This github release is of the monorepo, of which the top level package.json doesn't have a proper version, because it's not published per se.

What npm@6 was doing was fetching the tarball and creating a bad tgz file with no version, an error state that npm@7 is now refusing to enter.

[targos]

I suppose we should just replace npm pack url with a proper download of the tarball.