Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: enforce a space after commas #334

Merged
merged 1 commit into from
Jan 25, 2017
Merged

linter: enforce a space after commas #334

merged 1 commit into from
Jan 25, 2017

Conversation

gdams
Copy link
Member

@gdams gdams commented Jan 24, 2017

Checklist
  • npm test passes

@gibfahn
Copy link
Member

gibfahn commented Jan 24, 2017

While we're at it, are there any other things we could copy from https://github.com/nodejs/node/blob/master/.eslintrc.yaml ?

MylesBorins

This comment was marked as off-topic.

Sign in to view

gibfahn

This comment was marked as off-topic.

Sign in to view

@MylesBorins
Copy link
Contributor

@gibfahn I think we should likely have a longer conversation if we want to apply all the rules from the Node repo.

@gdams
Copy link
Member Author

gdams commented Jan 25, 2017

@gibfahn start a discussion and I'm more than happy to go through the rules from node and see if any are beneficial to us

@gdams gdams merged commit 328e3ea into nodejs:master Jan 25, 2017
@gibfahn gibfahn mentioned this pull request Jan 25, 2017
Open
@gdams gdams deleted the comma branch February 7, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdams @gibfahn @MylesBorins