lib: redirect tmpdir for modules being tested #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 94.77% 94.79% +0.01%
==========================================
Files 27 27
Lines 881 884 +3
==========================================
+ Hits 835 838 +3
Misses 46 46
Continue to review full report at Codecov.
|
The test for some modules write into `os.tmpdir()` and do not always clean up afterwards which can fill the temporary directory on our CI. Redirect the temporary directory for modules being tested into CITGM's `tmpDir` which gets removed at the end of the run. Refs: nodejs/build#1757
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for some modules write into
os.tmpdir()and do not alwaysclean up afterwards which can fill the temporary directory on our CI.
Redirect the temporary directory for modules being tested into CITGM's
tmpDirwhich gets removed at the end of the run.Refs: nodejs/build#1757
Checklist
npm testpasseshere