lookup: add https-proxy-agent

[lpinca]

This package has ~6 million weekly downloads and we broke it in
Node.js 10.0.0

Refs: nodejs/node#24474 (comment)

Checklist

• npm test passes
• contribution guidelines followed
  here

[codecov-io]

Codecov Report

Merging #752 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   96.22%   96.17%   -0.05%     
==========================================
  Files          27       30       +3     
  Lines         874      889      +15     
==========================================
+ Hits          841      855      +14     
- Misses         33       34       +1     

Impacted Files	Coverage Δ
lib/lookup.js	96.15% <0.00%> (-1.22%)	⬇️
bin/citgm-all.js	92.00% <0.00%> (-0.16%)	⬇️
bin/citgm.js	100.00% <0.00%> (ø)
lib/spawn.js	100.00% <0.00%> (ø)
lib/unpack.js	100.00% <0.00%> (ø)
lib/timeout.js	100.00% <0.00%> (ø)
lib/git-clone.js	100.00% <0.00%> (ø)
lib/common-args.js	100.00% <0.00%> (ø)
lib/create-options.js	100.00% <0.00%> (ø)
lib/temp-directory.js	100.00% <0.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e267f...89a71f3. Read the comment docs.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/86/

[lpinca]

@nodejs/citgm ping

[targos]

This fails on all supported versions of Node.js:

• 10: https://ci.nodejs.org/job/citgm-smoker-nobuild/838/
• 12: https://ci.nodejs.org/job/citgm-smoker-nobuild/839/
• 13: https://ci.nodejs.org/job/citgm-smoker-nobuild/840/
• 14: https://ci.nodejs.org/job/citgm-smoker-nobuild/837/

[lpinca]

Interesting. It seems that a build step (npm run build) is required before running tests. There is also a test failure due to recent stream changes.

These issues should be fixed before this can land.

[targos]

if there's a build script to run, you can specify it in a "scripts" property.
Example:

citgm/lib/lookup.json

Line 307 in a6c119b

"scripts": ["rebuild-tests", "test"],

[lpinca]

Ok, thanks Michaël. Trying to figure how to fix the failing tests now (this is why I want this in CITGM, we broke this module again).

[lpinca]

It should now fail only on Node.js 14 (TooTallNate/proxy-agents#104).

[targos]

Is it possible to cut a release so the module is fixed on Node.js 14 and 15, and we can merge this?

[lpinca]

See TooTallNate/proxy-agents#104 (comment). If maintainers are not responsive I think it does not make sense to add this.

[targos]

Is the module entirely broken on Node.js 14+ without the patch from TooTallNate/proxy-agents#104 ?

[lpinca]

Not completely broken, only if the proxy replies with a non 200 status code.

[lpinca]

https-proxy-agent@5.0.1 has been released. This should be finally ready to land.

[targos]

could you please rebase so we test the PR with the latest code?

[codecov-commenter]

Codecov Report

Merging #752 (d3acc07) into main (fcfc781) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files          28       28           
  Lines        2145     2145           
=======================================
  Hits         2069     2069           
  Misses         76       76           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfc781...d3acc07. Read the comment docs.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/154/

[targos]

CI looks good to me. The only failure is due to Ubuntu 18.04 which cannot run node 18.