Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: show stderr when getting project from npm fails #753

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

addaleax
Copy link
Member

Checklist
  • npm test passes (mostly – but failures seem unrelated)
  • tests are included
  • contribution guidelines followed
    here

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #753 into master will decrease coverage by 0.77%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   96.22%   95.44%   -0.78%     
==========================================
  Files          27       27              
  Lines         874      879       +5     
==========================================
- Hits          841      839       -2     
- Misses         33       40       +7
Impacted Files Coverage Δ
lib/grab-project.js 92.15% <88.88%> (+0.85%) ⬆️
lib/spawn.js 66.66% <0%> (-33.34%) ⬇️
lib/match-conditions.js 91.48% <0%> (-2.13%) ⬇️
bin/citgm.js 98.07% <0%> (-1.93%) ⬇️
bin/citgm-all.js 91.17% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e267f...3b2a73f. Read the comment docs.

@targos targos merged commit 84187a6 into nodejs:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants