lib: handle temporary directory removal errors #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously any errors occurring when removing the temporary directory during cleanup after a test were not caught and resulted in the `end` event not being emitted. For `citgm-all` this prevented moving onto the next module to test.
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
==========================================
- Coverage 96.08% 96.05% -0.03%
==========================================
Files 30 31 +1
Lines 894 913 +19
==========================================
+ Hits 859 877 +18
- Misses 35 36 +1
Continue to review full report at Codecov.
|
|
Compare the following citgm-smoker-nobuild runs with Node.js 14:
|
targos
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any errors occurring when removing the temporary directory
during cleanup after a test were not caught and resulted in the
endevent not being emitted. For
citgm-allthis prevented moving ontothe next module to test.
Refs: #802
Checklist
npm testpasseshere