Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot resolve path when building with EXTERNAL_PATH #93

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Apr 28, 2024

@guybedford guybedford merged commit 8ea767a into nodejs:main Apr 28, 2024
1 check passed
@mochaaP
Copy link
Contributor Author

mochaaP commented Apr 28, 2024

wow that's quick. Thanks!

mochaaP added a commit to mcha-forks/cjs-module-lexer that referenced this pull request Apr 28, 2024
@mochaaP
Copy link
Contributor Author

mochaaP commented Apr 28, 2024

Uh, I recalled why this was a thing. It should be import.meta.resolve("../lib/lexer.wasm") for tests to work without globally installing the module.

guybedford pushed a commit that referenced this pull request Apr 28, 2024
* tests: fix loading wasm when targeting external deps

* Revert "fix: cannot resolve path when build with EXTERNAL_PATH (#93)"

This reverts commit 8ea767a.
guybedford added a commit that referenced this pull request Apr 28, 2024
guybedford added a commit that referenced this pull request Apr 28, 2024
* Revert "tests: fix loading wasm when targeting external deps (#94)"

This reverts commit bcc6ce4.

* Revert "fix: cannot resolve path when build with EXTERNAL_PATH (#93)"

This reverts commit 8ea767a.

* Revert "Support building for externally shared js builtins (#91)"

This reverts commit 1c5072c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants