tests and bugfix for line-after-title #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
approved these changes
Oct 5, 2018
addaleax
approved these changes
Oct 7, 2018
|
Since I was explicitly added as an external contributor to this repo (probably by Evan some time back?), I'm going to assume it's OK for me to land a PR that's been approved by others. Hope that's OK. If I'm wrong, please revert! |
|
(It would be great to get this into a release so that Travis doesn't complain about pull requests with commits that only contain a title line.) |
4 tasks
|
@joyeecheung @evanlucas Any chance we can publish a new release so that we get rid of the false positive for contributors on Travis? Ref: nodejs/node#23339 (comment) |
|
I forgot that I have npm collaborator access...published a new release, thanks for the reminder! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for line-after-title.
Change line-after-title so that it does not report an error for commit messages that are a title line only.