Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for lint #260

Closed
SpencerKaiser opened this issue Apr 27, 2023 · 4 comments
Closed

Add GitHub Action for lint #260

SpencerKaiser opened this issue Apr 27, 2023 · 4 comments

Comments

@SpencerKaiser
Copy link
Contributor

SpencerKaiser commented Apr 27, 2023

When making a pull request, listing should be considered and branch protection should be enabled to require a pass from the lint action before a PR can be merged.

Note: there are quite a few files in the repo that need to be updated with yarn lint:fix before this can be turned on without creating new failures

@merceyz
Copy link
Member

merceyz commented Apr 27, 2023

It's already checked in

- name: "Check for linting errors"
run: corepack yarn lint

@SpencerKaiser
Copy link
Contributor Author

Ah... so it just not reporting for my PR? #259

@SpencerKaiser SpencerKaiser closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@merceyz
Copy link
Member

merceyz commented Apr 27, 2023

1 workflow awaiting approval
This workflow requires approval from a maintainer

Someone needs to approve it first.

@SpencerKaiser
Copy link
Contributor Author

Oof I missed that... welp, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants