-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a note about DNS to the generic HTTP error message #259
Conversation
…ing style in utils file
Updated error after latest push: Internal Error: Error when performing the request to https://registry.yarnpkg.com/yarn/-/yarn-1.3.1.tgz; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting
at ClientRequest.<anonymous> (/Users/skaiser/Dev/corepack/dist/corepack.js:43961:9)
at ClientRequest.emit (node:events:513:28)
at TLSSocket.socketErrorListener (node:_http_client:502:9)
at TLSSocket.emit (node:events:513:28)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) and to repro this locally, override your machine's DNS server to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits. Can we remove the unrelated changes? We can take them to a separate PR if you want.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
…ack into dns-error-suggestion
@aduh95 done! Sorry; I was just worried the CI would fail but it looks like there isn't an action for that 😬 I'll go open an issue |
Fixes #257