Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note about DNS to the generic HTTP error message #259

Merged
merged 6 commits into from
Apr 29, 2023
Merged

Adding a note about DNS to the generic HTTP error message #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5aee2fe
Adding a note about DNS to the generic HTTP error message
SpencerKaiser Apr 25, 2023
ad1f6a0
Adding troubleshooting section to README, updating error message, fix…
SpencerKaiser Apr 27, 2023
56aad7e
Apply suggestions from code review
SpencerKaiser Apr 27, 2023
97e4cf9
Reverting lint issues
SpencerKaiser Apr 27, 2023
c4732c7
Merge branch 'dns-error-suggestion' of github.com:SpencerKaiser/corep…
SpencerKaiser Apr 27, 2023
a52078e
Actually reverting formatting
SpencerKaiser Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,16 @@ network interaction.
- `HTTP_PROXY`, `HTTPS_PROXY`, and `NO_PROXY` are supported through
[`node-proxy-agent`](https://github.com/TooTallNate/node-proxy-agent).

## Troubleshooting

### Networking

There are a wide variety of networking issues that can occur while running `corepack` commands. Things to check:

- Make sure your network connection is active.
- Make sure the host for your request can be resolved by your DNS; try using `curl [URL]` from your shell.
- Check your proxy settings (see [Environment Variables](#environment-variables)).

## Contributing

See [`CONTRIBUTING.md`](./CONTRIBUTING.md).
Expand Down
2 changes: 1 addition & 1 deletion sources/httpUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function fetchUrlStream(url: string, options: RequestOptions = {})
});

request.on(`error`, err => {
reject(new Error(`Error when performing the request`));
reject(new Error(`Error when performing the request to ${url}; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting`));
});
});
}
Expand Down