Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): fix outdated "Contributing" section #199

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 20, 2022

@kenrick95
Copy link
Contributor

Somewhat related: when I started setup on this repo, I noticed CONTRIBUTING.md so I read there first, but couldn't find a setup guide, only when I scroll down README that I found the guide. Perhaps this repo setup guide should be there (or at least have a hyperlink) in CONTRIBUTING.md? Thanks

@@ -147,14 +147,16 @@ This command will retrieve the given package manager from the specified archive

## Contributing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this entire section should be moved to the CONTRIBUTING.md file? Then the README.md can link to it?

@aduh95 aduh95 merged commit 55005a9 into main Oct 24, 2022
@aduh95 aduh95 deleted the contributing-yarn-install branch October 24, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants