-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks if the new corepack home folder exists and creates it if necessary (Fix for issue #198) #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test and update the PR title and description to describe what is going on? Seeing Fix for issue #198
in the commit history doesn't really say much about what happened.
Thanks for sending that. However I don't think that's where you want to put that command, instead if should be before the corepack/sources/commands/Prepare.ts Lines 120 to 122 in 29da06c
|
Prepare is not Hydrate... where actually the error happens... |
Yeah we would need one before corepack/sources/commands/Hydrate.ts Line 66 in b77ed59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mkdir
call needs to happen just before tar.c
in Prepare.ts
and tar.x
in Hydrate.ts
.
@Gamadril Any chance you'll have time to address the remaining suggestions and add some tests so we can land this? |
hmm, seems to be more complicated than expected. will have to investigate more time... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would you like to add a fix and a test for the prepare
command as well?
No description provided.