chore: report error url on fetchUrlStream exception #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, can you fix the conflict please? |
|
@aduh95 Updated. It seems the other place has been fixed by another PR. |
aduh95
reviewed
Apr 29, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
I pushed a new commit to try fix typecheck. |
aduh95
reviewed
Apr 29, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
gao-sun
reviewed
Apr 29, 2023
| if (!(statusCode >= 200 && statusCode < 300)) | ||
| return reject(new Error(`Server answered with HTTP ${statusCode}`)); | ||
| const statusCode = response.statusCode; | ||
| if (statusCode != null && statusCode >= 200 && statusCode < 300) |
There was a problem hiding this comment.
@aduh95 just curious why eqeq is allowed? usually js/ts projects force eqeqeq instead of eqeq to avoid implicit conversions.
There was a problem hiding this comment.
IIRC it’s allowed only for null, because it’s the only value for which it’s useful instead of being confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR ISSUE LOCATING...