chore(deps): upgrade all npm dependencies #266
Conversation
| // @ts-expect-error TODO: decipher why this produces an error | ||
| if (range.test(name) && maxSV?.compare(name) !== 1) { |
There was a problem hiding this comment.
No idea why this code generates the following error:
error TS2339: Property 'compare' does not exist on type 'never'.
88 if (range.test(name) && maxSV?.compare(name) !== 1) {
There was a problem hiding this comment.
| // @ts-expect-error TODO: decipher why this produces an error | |
| if (range.test(name) && maxSV?.compare(name) !== 1) { | |
| if (range.test(name) && maxSV && maxSV.compare(name) !== 1) { |
This works so potentially a TypeScript bug?
There was a problem hiding this comment.
| // @ts-expect-error TODO: decipher why this produces an error | |
| if (range.test(name) && maxSV?.compare(name) !== 1) { | |
| if (range.test(name) && (maxSV as semver.SemVer | undefined)?.compare(name) !== 1) { |
This also don't trigger the error, so definitely a TS bug, I guess we just have to wait for them to fix it.
| // @ts-expect-error TODO: decipher why this produces an error | ||
| if (range.test(name) && maxSV?.compare(name) !== 1) { |
There was a problem hiding this comment.
| // @ts-expect-error TODO: decipher why this produces an error | |
| if (range.test(name) && maxSV?.compare(name) !== 1) { | |
| if (range.test(name) && maxSV && maxSV.compare(name) !== 1) { |
This works so potentially a TypeScript bug?
| import {describe, beforeEach, it, expect} from '@jest/globals'; | ||
| import {Filename, ppath, xfs, npath} from '@yarnpkg/fslib'; | ||
| import {delimiter} from 'path'; | ||
| import {delimiter} from 'node:path'; | ||
| import process from 'node:process'; |
There was a problem hiding this comment.
These changes shouldn't be necessary, these are all global by default.
There was a problem hiding this comment.
It's indeed not necessary, more like a personal preference.
There was a problem hiding this comment.
Sure, but they don't really belong in a chore(deps): upgrade all npm dependencies commit.
There was a problem hiding this comment.
Fair enough, I thought at first it was necessary for this PR of the output of https://github.com/nodejs/corepack/actions/runs/5022431482/jobs/9005884303, turns out it was not and I left them because I liked them. My bad.
No description provided.