Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev dependency proxy-agent to 6.2.2 #283

Merged
merged 1 commit into from
Jul 14, 2023
Merged

chore: update dev dependency proxy-agent to 6.2.2 #283

merged 1 commit into from
Jul 14, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 13, 2023

This is to update the indirect vm2 dependency and resolve some dependabot alerts.

This is to update the indirect vm2 dependency and resolve some
dependabot alerts.
@merceyz
Copy link
Member

merceyz commented Jul 13, 2023

This PR doesn't change the vm2 version, it's locked here

"vm2": "patch:vm2@npm:3.9.9#.yarn/patches/vm2-npm-3.9.9-03fd1f4dc5.patch"
.

@arcanis
Copy link
Contributor

arcanis commented Jul 13, 2023

Ah right, we completely disabled vm2 to avoid this kind of problem. Still, the warnings from automation will be annoying.

I wonder if we could avoid it by using a link/portal rather than a patch, to completely prevent vm2 from being in the lockfile? 🤔

@Trott
Copy link
Member Author

Trott commented Jul 14, 2023

Going to go ahead and land as it updates a few things and is hopefully harmless (and might quiet the automation). Feel free to revert or force push out if I'm messing anything up by doing that....

@Trott Trott merged commit 98338b3 into nodejs:main Jul 14, 2023
@Trott Trott deleted the proxy-agent branch July 14, 2023 00:50
@Trott
Copy link
Member Author

Trott commented Jul 14, 2023

Ugh, it didn't resolve a single warning... :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants