add http redirect support #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Sep 6, 2023
sources/httpUtils.ts
Outdated
| if (statusCode >= 200 && statusCode < 300) | ||
| return resolve(response); | ||
|
|
||
| if ((statusCode === 301 || statusCode === 302 || statusCode === 307 || statusCode === 308) && response.headers.location) { |
There was a problem hiding this comment.
Suggested change
| if ((statusCode === 301 || statusCode === 302 || statusCode === 307 || statusCode === 308) && response.headers.location) { | |
| if ([301, 302, 303, 307].includes(statusCode) && response.headers.location) { |
This might be easier to read
styfle
reviewed
Sep 6, 2023
README.md
Outdated
| @@ -228,6 +228,9 @@ same major line. Should you need to upgrade to a new major, use an explicit | |||
| manager versions that will be required for the projects you'll run, using | |||
| `corepack install -g --cache-only`). | |||
|
|
|||
| - `COREPACK_FETCH_MAX_REDIRECTS` sets the maximum number of HTTP redirects should | |||
There was a problem hiding this comment.
Add this to tests/setupTests.js to ensure this env var is not set.
Also this probably needs to add a test when the env var is set.
|
Any future plans on this pr or it's safe to continue working on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #302