Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support redirections #341

Merged
merged 15 commits into from
Dec 29, 2023
Merged

feat: Support redirections #341

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9490fd2
feat: support redirections
guibwl Dec 14, 2023
5d593a9
feat 307 308 supported
guibwl Dec 14, 2023
33d99dc
fix spell wrong
guibwl Dec 14, 2023
02522cb
feat: handle `error` for redirection
guibwl Dec 16, 2023
1a58ba0
feat: add httpUtils tests
guibwl Dec 16, 2023
eef8cdd
Update tests/httpUtils.test.ts
guibwl Dec 17, 2023
69d4eea
fix: wrong word
guibwl Dec 17, 2023
41fc612
fix: misnamed
guibwl Dec 17, 2023
7101e28
fix: misnamed and definition is not concis
guibwl Dec 17, 2023
6164530
fix: better way to get statusCode
guibwl Dec 17, 2023
2be8393
Update sources/httpUtils.ts
guibwl Dec 27, 2023
fd13b93
Merge branch 'main' into main
guibwl Dec 27, 2023
5caead7
Update tests/httpUtils.test.ts
guibwl Dec 27, 2023
dda29e2
Update tests/httpUtils.test.ts
guibwl Dec 27, 2023
6fb8bf0
fix eslint(arca/curly) in httpUtils.test.ts
guibwl Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sources/httpUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,20 @@ export async function fetchUrlStream(url: string, options: RequestOptions = {})
const proxyAgent = new ProxyAgent();

return new Promise<IncomingMessage>((resolve, reject) => {
const request = https.get(url, {...options, agent: proxyAgent}, response => {
const creatRequest = (url: string) => https.get(url, {...options, agent: proxyAgent}, response => {
const statusCode = response.statusCode;

if (statusCode === 301 || statusCode === 302)
guibwl marked this conversation as resolved.
Show resolved Hide resolved
return creatRequest(response.headers.location);

if (statusCode != null && statusCode >= 200 && statusCode < 300)
return resolve(response);

return reject(new Error(`Server answered with HTTP ${statusCode} when performing the request to ${url}; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting`));
});

const request = creatRequest(url);

request.on(`error`, err => {
reject(new Error(`Error when performing the request to ${url}; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting`));
});
Expand Down