-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: store nocks in a sqlite database #374
Conversation
bfacbd1
to
3264379
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this approach will not introduce a conflict-hell, if virtually all PRs will touch the same binary file.
71903e8
to
ec2872b
Compare
Yeah, that's the downside of this approach, any new nock will cause a conflict. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
8bdc7f9
to
b7f6f71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems a good idea; slightly worried about the risk of conflicts too (especially if it breaks the "Update this PR" button in GH), but it's probably fine to try it and iterate as needed.
Storing the nocks in a SQLite database enables easily sharing nocks between tests run in different processes in parallel.
This reduces the storage space needed for the nocks:
It avoids the
v8.serialize
/v8.deserialize
issues encountered in #365.The database is portable so the version of Node.js used to generate it doesn't matter.