Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update TSC invitation list #85

Merged
merged 2 commits into from
Feb 17, 2020
Merged

update TSC invitation list #85

merged 2 commits into from
Feb 17, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 17, 2020

@nodejs/tsc

@Trott Trott mentioned this pull request Feb 17, 2020
Closed
2 tasks
@mhdawson
Copy link
Member

mhdawson commented Feb 17, 2020 •
edited
Loading

@Trott Ruben was added as an observer in #83 and showed up in the recent meeting invite.

If you think he needs to be part of the invited list instead of observer, then you should add the removal of him from the observer list to this PR.

@Trott
Copy link
Member Author

Trott commented Feb 17, 2020

@Trott Ruben was added as an observer in #83 and showed up in the recent meeting invite.

If you think he needs to be part of the invited list instead of observer, then you should add the removal of him from the observer list to this PR.

Ah, didn't realize there were two lists....

@Trott
Copy link
Member Author

Trott commented Feb 17, 2020

Ah, didn't realize there were two lists....

All fixed up.

mhdawson
mhdawson approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Landing since this is a reflection of reality and already has 3 approvals

@mhdawson mhdawson merged commit 22be38d into master Feb 17, 2020
@jasnell
Copy link
Member

jasnell commented Feb 17, 2020

@gireeshpunathil should be added as an observer also given that @mcollina has nominated him back to coincide with @BridgeAR's nomination: nodejs/TSC#817 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @mhdawson @jasnell @targos