-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bestpractices: add crash pre-requisites #285
Conversation
documentation/crash/crash_setup.md
Outdated
Yama security policy inhibits a second process from collecting dump, | ||
practically rendering `gcore` unusable. | ||
|
||
`setcap cap_sys_ptrace=+ep `which gdb`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me if this is to address the problem of gcore not working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhdawson - addressed, added a line that explains what we are doing.
Pushed a few commits to do minor fixup and some suggested changes as well. A more structural suggestion is that we should organize it into the following format: IntroductionWhat you have for the introduction with additional paragraphs for
Common issuesCover common issues in generating the key artifacts.
Recommended best practiceThis section provides specific recommendations for how to configure your systems in advance to be ready in order to be ready to investigate crashes. Ensuring enough disk spaceyour existing content on how to size. Maybe talk about cleanup/management of cores to avoid space problems here instead of later on? Configuring to ensure core generation
Additional information
Let me know what you think about this structure/organization. |
b304d0a
to
2640f91
Compare
@mhdawson - I have addressed all of your review comments. PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @mhdawson . Can I get one more review please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, you could call out that the user will need the exact same node binary to inspect your core dump. Or they need to bundle it into the core dump.
e0725eb
to
471aa1b
Compare
@hekike - can I add that statement in my second part? as here we are talking about the production system, and this one is for the |
@gireeshpunathil makes sense! |
bceb4ce
to
3e283aa
Compare
3e283aa
to
38a577a
Compare
landed as 38a577a |
This covers the preparation of crash diagnostics
Few caveats:
thanks!
Refs: #254