update: cleanup profiling root folder #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes sense to me to avoid duplicating good content that is out there. Helping people get to that content adds value. |
|
It looks like this would just add those references, so it would still make sense? |
I thinking in close this PR and open an issue to track the real missing tutorials. However, I'm fine by just adding a reference in those cases. What do you think? |
gireeshpunathil
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/diagnostics
I was writing the tutorial for
--profusage but looks like https://nodejs.org/en/docs/guides/simple-profiling/ did a great job on this context and there is no reason to document it again.That said, I would like to revive #454 in order to document only missing tutorials. If there are no objections, I would close this PR and open a new issue to tracking missing tutorials.