Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected yarn version on node 10 and 13 #1218

Closed
wants to merge 1 commit into from
Closed

Corrected yarn version on node 10 and 13 #1218

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link

This change was made for node 12, but forgotten for 10 and 13.

@SimenB
Copy link
Member

SimenB commented Feb 19, 2020

We only update the yarn version on new releases of node that are not security releases.

Node 13 will be updated when 13.9.0 are available on Alpine (possibly blocked by nodejs/node#31858) and 10 will be updated whenever 10 has a new release.

See https://github.com/nodejs/docker-node/blob/master/CONTRIBUTING.md#version-updates and https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md#upgradingdowngrading-yarn for how to upgrade yourself if you want to

@SimenB SimenB closed this Feb 19, 2020
@GrahamCampbell
Copy link
Author

Hopefully, there will be at least one more release of node 10, otherwise you will never put yarn 1.22 in the image?

@GrahamCampbell
Copy link
Author

They are scheduled to go into maintenance only in April 2020, so hopefully they will decide to do a release with some new stuff before then.

@SimenB
Copy link
Member

SimenB commented Feb 19, 2020

Node 10 will be supported so long as it's not EOL (which is slated for April 2021), so I assume we'll update at some point before that. But we don't want to change the version (unless it's a security release) within an existing version of node.

@GrahamCampbell
Copy link
Author

The problem was:

We only update the yarn version on new releases of node that are not security releases.

Between April 2020 and 2021, the only node 10 releases will be security releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants