Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js v13.x to v13.10.1 with Yarn v1.22.1 #1219

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

13/alpine3.11/Dockerfile Outdated Show resolved Hide resolved
@PeterDaveHello
Copy link
Member Author

I've excluded the updates for Alpine Linux to prevent blocking.

@PeterDaveHello PeterDaveHello marked this pull request as ready for review February 20, 2020 10:42
@PeterDaveHello PeterDaveHello requested a review from a team February 20, 2020 10:42
@SimenB
Copy link
Member

SimenB commented Feb 20, 2020

generate-stackbrew-library.sh doesn't handle that, see docker-library/official-images#7429 (comment)

@PeterDaveHello
Copy link
Member Author

Maybe just manually handle that?

@SimenB
Copy link
Member

SimenB commented Feb 20, 2020

@rvagg any idea why the alpine build is not available? Is it nodejs/node#31858?

@nschonni
Copy link
Member

Sorry, I did open up nodejs/unofficial-builds#15 yesterday

@SimenB
Copy link
Member

SimenB commented Feb 20, 2020

Ah, cool. Thanks for the link 👍

@rvagg
Copy link
Member

rvagg commented Feb 21, 2020

are you getting successful builds on the other platforms? or are you not using the tarballs to build? I thought the build error was universal for all tarballs and unofficial-builds is basically doing the same compile dance as you're doing in your dockerfiles?

@PeterDaveHello
Copy link
Member Author

@rvagg for the other variants, we just download the tarball and extract it without the builds.

@rvagg
Copy link
Member

rvagg commented Feb 24, 2020

Oh, of course, it's only where we need to compile from source - alpine where this is a problem. My advice is to write this release off for alpine. But if someone wanted to put in effort to special-case it it's possible to hack in a manual download o the missing piece just for this one.

@csvn
Copy link

csvn commented Mar 4, 2020

Node v13.10 was just released, but it seems to have the same issue as before: nodejs/node#31858 (comment)

@nschonni
Copy link
Member

nschonni commented Mar 5, 2020

Looks like 13.10.1 will fix the source builds. Should we still land this before that PR?

@PeterDaveHello PeterDaveHello changed the title Update node.js v13.x to v13.9.0 with Yarn v1.22.0 Update node.js v13.x to v13.10.1 with Yarn v1.22.1 Mar 5, 2020
@PeterDaveHello
Copy link
Member Author

@nodejs/docker maybe we just skip those, directly update to v3.10.1 with Yarn v1.22.1?

I've updated the PR, let's see if we all agree this method, thanks.

@PeterDaveHello PeterDaveHello requested review from pesho, Starefossen and a team March 5, 2020 05:40
@SimenB
Copy link
Member

SimenB commented Mar 5, 2020

Yeah, I think this makes sense 👍

@nodejs-github-bot
Copy link
Collaborator

Created PR to the official-images repo (docker-library/official-images#7575). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@PeterDaveHello PeterDaveHello deleted the update-node.js branch March 5, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants