-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node.js v13.x to v13.10.1 with Yarn v1.22.1 #1219
Conversation
PeterDaveHello
commented
Feb 19, 2020
•
edited
Loading
edited
- https://nodejs.org/en/blog/release/v13.10.1/
- https://github.com/nodejs/node/releases/tag/v13.10.1
- https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#13.10.1
981d264
to
cb9ec80
Compare
I've excluded the updates for Alpine Linux to prevent blocking. |
|
Maybe just manually handle that? |
@rvagg any idea why the alpine build is not available? Is it nodejs/node#31858? |
Sorry, I did open up nodejs/unofficial-builds#15 yesterday |
Ah, cool. Thanks for the link 👍 |
are you getting successful builds on the other platforms? or are you not using the tarballs to build? I thought the build error was universal for all tarballs and unofficial-builds is basically doing the same compile dance as you're doing in your dockerfiles? |
@rvagg for the other variants, we just download the tarball and extract it without the builds. |
Oh, of course, it's only where we need to compile from source - alpine where this is a problem. My advice is to write this release off for alpine. But if someone wanted to put in effort to special-case it it's possible to hack in a manual download o the missing piece just for this one. |
Node v13.10 was just released, but it seems to have the same issue as before: nodejs/node#31858 (comment) |
Looks like 13.10.1 will fix the source builds. Should we still land this before that PR? |
cb9ec80
to
6bc7fe5
Compare
@nodejs/docker maybe we just skip those, directly update to v3.10.1 with Yarn v1.22.1? I've updated the PR, let's see if we all agree this method, thanks. |
Yeah, I think this makes sense 👍 |
Created PR to the official-images repo (docker-library/official-images#7575). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |