-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add templates for generating the variants #144
Conversation
Here is the diff the the dockerfile generated by this |
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \ | ||
done | ||
|
||
ENV NPM_CONFIG_LOGLEVEL info |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I think this PR should be renamed since it's about adding templates for the various existing variants and not does not add an Alpine variant (which presumably will be a separate PR :) |
@@ -0,0 +1,33 @@ | |||
FROM buildpack-deps:jessie-curl |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
So I think it's time for me to review the 0.10 and 0.12 image with respect to how the slim variant is built an switch to the method used by 4.x and 5.x. That should help in terms if templating the updates. |
I'm a bit confused what is needed to get this merge, especially since it's pending other decision. Should I separate the commit into the templates and the script so we could merge the template, keep working on it then update scripts when the template is finalized? |
A couple of things need to happen outside of this PR:
Once the above two issues are resolve we should be able to move forward with this PR |
PR to make the 0.10 and 0.12 slim variants consistent: #149 |
Also, to answer your previous question, I think it would be better to wait for the other issues to be resolved and then rebase this rather than split up the PR. |
Use buildpack-deps:jessie-curl for 0.10 and 0.12 slim images. See #144
I just merged #149. In terms of #57 I think we should just modify the I'll merge this now and work on a follow update for the And thanks for this @LaurentGoderre ! |
No description provided.