Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use folder commmit for Stackbrew #1546

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Aug 17, 2021

Description

Current script just takes the commit hash for the Dockerfile, so when the commit bit was fixed, it isn't getting picked up for the upstream PR. Now it will use the whole variant folder when looking for the latest commithash

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni nschonni merged commit 6c94e03 into nodejs:main Aug 17, 2021
@nschonni nschonni deleted the stackbrew-directory branch August 17, 2021 19:31
@github-actions
Copy link

Created PR on the official-images repo (docker-library/official-images#10748). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants