-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 4.0.0 #42
Node 4.0.0 #42
Conversation
+1 |
2 similar comments
+1 |
+1 |
+1 |
+1 |
👍 |
@chorrell what else do we need to do? I am happy to click the buttons and make a PR to fix docker-library/official-images#1035 if nothing is missing. |
@hmalphettes We just need to merge this and then submit a PR for https://github.com/docker-library/official-images. If you're cool with that then click away! The PR to official-images will also land the org switch as well as introducing 4.0.0 |
@chorrell is it already published to registry? |
👏 Great job @chorrell |
@CentaurWarchief AFAIK the PR still needs to be submitted and merged for https://github.com/docker-library/official-images. |
@CentaurWarchief Ah thanks, missed that merge completely. 👍 |
We should be good now, just waiting on docker-library/official-images#1036 to land. @hmalphettes we should be good now :) |
Cool. Waiting for it. 🍻 |
+1 |
🎉 thanks @chorrell !!! 😄 |
This adds Node.js v4.0.0 and sets it as the "latest" image.
Things to note:
Test build via test-build.sh passes :)
Closes #39
cc @nodejs/docker