Travis improvements #607

chorrell · 2018-01-07T22:14:52Z

This adds a bunch of minor improvements to the travis-ci config:

Install and use the latest version of docker (via the docker-ce package).
Explicitly set the distro to Trusty.
Set the language to node_js and with the latest LTS version installed. Prior to this the image would default to the ruby language which always seemed weird to me. As a bonus this means we don't need to install node for the doc check

Also: don't install node for doc check, it's now already installed

SimenB · 2018-01-08T08:33:35Z

Nice!

chorrell · 2018-01-31T20:00:18Z

@nodejs/docker Is this good to merge now?

SimenB · 2018-01-31T20:02:51Z

Yeah, go for it

chorrell · 2018-01-31T20:24:27Z

Cool, thanks!

chorrell added 3 commits January 7, 2018 12:40

Install newer version of Docker

5340de6

Always use Trusty

9139b23

Set language to node_js and use latest LTS version

172a33e

Also: don't install node for doc check, it's now already installed

This comment was marked as off-topic.

Sign in to view

chorrell merged commit 2553444 into nodejs:master Jan 31, 2018

chorrell deleted the travis-improvements branch January 9, 2019 21:27

Provide feedback